Re: [VOTE] linkerd moving to incubation


Brian Grant
 

I assume the maintainers govern all linkerd repositories, since other repositories do not contain MAINTAINERS.md files.

I see (super-)maintainers can be added via nomination and vote. It may be useful to develop a particular contribution bar for (super-)maintainers, such as number of commits or duration on the project or number of subsystems they have worked on, so contributors know roughly what to strive for and existing (super-)maintainers have guidelines for nominating new members of those groups.

Given that the PR backlog doesn't seem to be growing, I assume that the current number of super-maintainers is sufficient to keep up with the current review/approval load.

Something we (CNCF) need to think about that isn't specific to Linkerd is what activity level(s) we expect, since some projects are naturally larger and/or more active than others.

Clearly we do care about contributor diversity, so that's something we should explore whether/how CNCF could help improve that in the future.

Though there is more work to do, I believe that linkerd meets the bar for incubation.

+1 binding

On Tue, Mar 20, 2018 at 8:11 AM William Morgan <william@...> wrote:
Whoops, thanks for pointing that out. I count 3 PRs out of the last 18 or so that violated the governance rules about requiring a super-maintainer review, all minor. We're still adjusting to some of these changes... this will improve.

-William

On Tue, Mar 20, 2018 at 7:19 AM, Justin Cormack via Lists.Cncf.Io <justin.cormack=docker.com@...> wrote:
0 (non binding)

The governance seems confused and I am not sure it technically meets the criteria of number of committers.
The governance doc[1] states "All PRs must receive approval from at least one super maintainer before merge",
so as there are only two super maintainers only two people are "someone who can accept contributions to
some or all of the project".

In practise this is ignored, and there are additional people with Github commit access, not listed as maintainers
who are merging many of the PRs, often without super maintainer approval. I know the CNCF does not require
full governance at this stage but the fact that the newly added governance seems to be ignored is a concern,
as external contributors are being treated differently.



On Thu, Mar 15, 2018 at 5:28 PM, Chris Aniszczyk <caniszczyk@...> wrote:
The linkerd team has requested a move to the incubation level: https://github.com/cncf/toc/pull/86 

You can see the project statistics here: https://linkerd.devstats.cncf.io/ and the linkerd project believes they meet the incubation criteria requirements:

- Used successfully in production by at least three independent end users of sufficient scale and quality: https://github.com/linkerd/linkerd/blob/master/ADOPTERS.md
- Have a healthy number of committers: https://github.com/linkerd/linkerd/blob/master/MAINTAINERS.md
- Demonstrate a substantial ongoing flow of commits and merged contributions: https://github.com/linkerd/linkerd/releases and https://github.com/linkerd/linkerd/graphs/contributors

Please vote (+1/0/-1) by replying to this thread; the full incubation proposal located here: https://github.com/cncf/toc/pull/86

Remember that the TOC has binding votes only, but we do appreciate non-binding votes from the community as a sign of support!

--
Chris Aniszczyk (@cra) | +1-512-961-6719



Join cncf-toc@lists.cncf.io to automatically receive all group messages.